Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI::writeBytes first param is not const #3241

Closed
Makuna opened this issue Sep 21, 2019 · 1 comment · Fixed by #3242
Closed

SPI::writeBytes first param is not const #3241

Makuna opened this issue Sep 21, 2019 · 1 comment · Fixed by #3242

Comments

@Makuna
Copy link

Makuna commented Sep 21, 2019

Description:

SPI::writeBytes is defined differently between Esp82666 and Esp32; where the first param is const on esp8266 it is not on Esp32. Since the data should not be overwritten, this param should be marked as const.
Esp32 => void SPIClass::writeBytes(uint8_t * data, uint32_t size)
Esp8266 => void SPIClass::writeBytes(const uint8_t * data, uint32_t size);

This causes compile issues when the environement is set to strict compile option.

@me-no-dev
Copy link
Member

done ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants