Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebServer.cpp still using DEBUG_ESP_HTTP_SERVER logging #2355

Closed
meltdown03 opened this issue Jan 20, 2019 · 1 comment · Fixed by #2359
Closed

WebServer.cpp still using DEBUG_ESP_HTTP_SERVER logging #2355

meltdown03 opened this issue Jan 20, 2019 · 1 comment · Fixed by #2359

Comments

@meltdown03
Copy link
Contributor

meltdown03 commented Jan 20, 2019 •
edited
Loading

Git: master branch - as of 1/19/2019
I just noticed that the Webserver library is the only lib that's still using DEBUG_ESP_HTTP_SERVER, requiring the extra flag to be added when compiling. All others use log_d()
libraries/WebServer/WebServer.cpp
Not sure if it was just missed or intentionally left that way. Either way, thought I would bring it to attention.

Thank you ALL for all you do!
@meltdown03 meltdown03 mentioned this issue Jan 20, 2019
Merged
@meltdown03
Copy link
Contributor Author

meltdown03 commented Jan 20, 2019 •
edited
Loading

Sorry About all that nonsense above, never really use GitHub on the web.

@meltdown03 meltdown03 reopened this Jan 20, 2019
me-no-dev pushed a commit that referenced this issue Jan 22, 2019
@meltdown03 @me-no-dev
Webserver library - fix logging (#2355) (#2359)
29d5987 
* Webserver fix logging (#1)

* Change logging to use esp32-hal-log.h

fixes #2355

* adjust log parameter output positions, reduce lines

The DEBUG_ESP method used less lines than I originally set `log_v` to use when displaying the details of the received params ("@" and "=" indexes, and File info on a single line)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Webserver library - fix logging (#2355)
1 participant
@meltdown03