Skip to content

Commit

Permalink
Fix BananaPi-BIT and T-Beam pin definitions (#2343)
Browse files Browse the repository at this point in the history 
* Fix BananaPi-BIT DAC definition

* Update t-beam too
  • Loading branch information
@OttoWinter @me-no-dev
OttoWinter authored and me-no-dev committed Jan 22, 2019
1 parent 3350476 commit 489feb8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions variants/bpi-bit/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ static const uint8_t P16 = 5;
static const uint8_t P19 = 22;
static const uint8_t P20 = 21;

static const uint8_t DAC1 = 26;
static const uint8_t DAC2 = 25;
static const uint8_t DAC1 = 25;
static const uint8_t DAC2 = 26;

#endif /* Pins_Arduino_h */
#endif /* Pins_Arduino_h */
6 changes: 3 additions & 3 deletions variants/t-beam/pins_arduino.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ static const uint8_t T1 = 0;
static const uint8_t T2 = 2;
static const uint8_t T4 = 13;
static const uint8_t T6 = 14;
static const uint8_t T8 = 32;
static const uint8_t T9 = 33;
static const uint8_t T8 = 33;
static const uint8_t T9 = 32;

static const uint8_t DAC2 = 25;
static const uint8_t DAC2 = 26;

#endif /* Pins_Arduino_h */

1 comment on commit 489feb8

@cyberman54
Copy link
Contributor

@cyberman54 cyberman54 commented on 489feb8 Jan 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OttoWinter There is no GPIO26 pin on TTGO T-Beam boards, only GPIO25 is wired to a pin, it's pin nr. 6 in header connector U12.

ESP32 has two 8-bit DAC, connected to GPIO25 (Channel 1) and GPIO26 (Channel 2).

So for T-Beam board we have DAC1 = 25 and no DAC2.

Please sign in to comment.