Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nom's lexical feature #6

Merged
merged 2 commits into from
May 27, 2020
Merged

Disable nom's lexical feature #6

merged 2 commits into from
May 27, 2020

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented May 27, 2020

I have not tested this!

It doesn't look like xcursors parsing code would benefit from it in any way and this significantly reduces the amount of transitive dependencies.

The std feature could probably be dropped in favor of the alloc feature, though that only really makes sense if this crates becomes a no_std crate as well (which, if the std::env usage is feature-gated, seems relatively easy to do, but may not actually be useful to anyone).

@jplatte
Copy link
Contributor Author

jplatte commented May 27, 2020

Oh, I thought I could just open this PR via the GitHub web editor and let CI check whether this actually works. That of course only works if there is CI 😅

Cargo.toml Outdated Show resolved Hide resolved
@esposm03
Copy link
Owner

Nice catch @jplatte! I tested your changes locally and they work, so I'm merging now.

The std feature could probably be dropped in favor of the alloc feature, though that only really makes sense if this crates becomes a no_std crate as well (which, if the std::env usage is feature-gated, seems relatively easy to do, but may not actually be useful to anyone).

I'm going to do a (hopefully good) refactor to this crate when school ends, so I'll see then.

That of course only works if there is CI

Yeah, I wanted it too, but for some reason Github Actions complained that it couldn't find the workflow file (probably I changed it and made it invalid ^^). I'll try again now.

@esposm03 esposm03 merged commit 511418f into esposm03:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants