Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import getLocalTime() from esp32/Arduino #8413

Merged
merged 5 commits into from
Jan 4, 2022
Merged

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Dec 16, 2021

follows and closes #8407

@d-a-v d-a-v added this to the 3.1 milestone Dec 16, 2021
@@ -0,0 +1,19 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might better be put into the existing time.cpp file instead of making a new one.

Also, a new file would need the GPL headers/etc.

Copy link
Collaborator Author

@d-a-v d-a-v Jan 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might better be put into the existing time.cpp file instead of making a new one.

time.cpp is not compiled in host mode. This new file would.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function is now in time.cpp, the other new file is removed.

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d-a-v d-a-v merged commit a05a71f into esp8266:master Jan 4, 2022
@d-a-v d-a-v deleted the getlocaltime branch January 4, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants