Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default FW to "2.2.2-dev(38a443e)" (menu:2.2.1+100) #6272

Merged
merged 12 commits into from
Jul 9, 2019

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Jul 8, 2019

This is a convenience PR

  • fix a LittleFS bug: avoid crash at boot when FS size is 0
  • debug message in FS when implementation cannot start
  • change defaults in arduino IDE menus

in details, new default options:

  • ESP-NOW is working
  • flash size:
    • 1M for generic board (instead of 512K)
    • FS: maximal not-0 size with maximal size for sketch+OTA

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with just a couple questions as to the logic of serial baud switching....

_lfs_cfg.block_cycles = 16; // TODO - need better explanation
_lfs_cfg.cache_size = 64;
_lfs_cfg.block_count =_blockSize? _size / _blockSize: 0;
_lfs_cfg.block_cycles = 16; // TODO - need better explanation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space to tab problems?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@@ -68,7 +68,7 @@
'crystalfreq_menu',
'flashfreq_menu',
'flashmode_menu',
'512K', '1M', '2M', '4M', '8M', '16M',
'1M', '2M', '4M', '8M', '16M', '512K',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the 512K moved to then end of lists in other spots, is this on purpose?

Copy link
Collaborator Author

@d-a-v d-a-v Jul 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, so the default flash space for esp8266 generic board is 1MB.
512K boards are obsolete and not sold anymore, also abandoned / not usable in nonos-sdk-v3.
We still have them anyway, but no more as default.

@@ -542,7 +542,7 @@
'flashfreq_40',
'4M',
],
'serial': '57',
# 'serial': '57',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why disabling the hardcoded serial speeds? If it's 921 it will silently use 400k. If it's 56K, there might be a HW reason for it on those specific boards....

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(like a really, really cheap USB<->serial chip, or high resistance/capacitance on the lines due to something else like LEDs sharing the pin, etc.)

Copy link
Collaborator Author

@d-a-v d-a-v Jul 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true. I was wrongly thinking esptool would try at lower rates.
I will revert this.
edit: done

@@ -1573,7 +1573,7 @@ def usage (name,ret):
# entry point

lwip = 2
default_speed = '115'
default_speed = '921'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little worried here about the speed change, see above comment.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speed change is now reverted.

@d-a-v d-a-v merged commit 1b3ac4f into esp8266:master Jul 9, 2019
@d-a-v d-a-v deleted the defaultFW2.2.1+100 branch July 9, 2019 18:18
mhightower83 added a commit to mhightower83/Arduino that referenced this pull request Jul 10, 2019
Switch default FW to "2.2.2-dev(38a443e)" (menu:2.2.1+100) (esp8266#6272)
@ascillato
Copy link
Contributor

@d-a-v @earlephilhower

We have tested this new version of the core with SDK on Tasmota (on several devices at once) and it is working very good. Great work 👍 Congratulations.

Several Tasmota users were stuck at 2.3.0 core due was the most stable with some old wifi routers. Now this new version seems to be the new stable core for all types of routers!!! No more mqtt socket disconnections!

Are you planning to release a new version any time soon? That would be great!

Thanks a lot for your hard work

@d-a-v
Copy link
Collaborator Author

d-a-v commented Jul 11, 2019

were stuck at 2.3.0

Thanks, very good to hear you are finally able to use latests versions !

Are you planning to release a new version any time soon? That would be great!

Currently 2.6.0 is planned for September, 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants