Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDNS: fix random crash on startup #6261

Merged
merged 13 commits into from
Sep 5, 2019
Merged

MDNS: fix random crash on startup #6261

merged 13 commits into from
Sep 5, 2019

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Jul 6, 2019 •
edited
Loading

MDNS:

  • AP address is used by default when STA is also present
  • enforce selected interface
  • igmp: force selected interface

Arduino menu:

  • mDNS debug option

edit:
Fixes #6463

@d-a-v d-a-v changed the title UDP: fix address helpers, MDNS minor updates MDNS minor updates Jul 6, 2019
@d-a-v d-a-v closed this Jul 9, 2019
@d-a-v d-a-v reopened this Jul 9, 2019
@d-a-v d-a-v mentioned this pull request Jul 23, 2019
Open
6 tasks
@d-a-v d-a-v changed the title MDNS minor updates MDNS: fix random crash on startup Jul 24, 2019
@d-a-v d-a-v requested a review from devyte July 24, 2019 16:26
@d-a-v d-a-v mentioned this pull request Aug 29, 2019
Closed
5 tasks
@d-a-v d-a-v added this to the 2.6.0 milestone Sep 4, 2019
devyte
devyte approved these changes Sep 5, 2019
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing jumps out at me. However, I think some of the logic will require rework to allow mdns to work with the lwip Ethernet.

@earlephilhower earlephilhower merged commit 5ca0bde into esp8266:master Sep 5, 2019
@d-a-v d-a-v deleted the udpmdnsfix branch September 5, 2019 23:06
@OttoWinter OttoWinter mentioned this pull request Nov 9, 2019
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

MDNS Not working properly after this commit 9009b8
3 participants
@d-a-v @devyte @earlephilhower