Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix String.replace overlapping strcpy #5966

Merged
merged 4 commits into from
Apr 10, 2019
Merged

Fix String.replace overlapping strcpy #5966

merged 4 commits into from
Apr 10, 2019

Conversation

earlephilhower
Copy link
Collaborator

Fixes #5949

Adds a test from the issue above and fixes the problem valgrind found.

d-a-v
d-a-v approved these changes Apr 9, 2019
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unfortunate hidden commit in this PR

devyte
devyte requested changes Apr 10, 2019
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR needs fixing, but code change LGTM

@earlephilhower
Fix String.replace overlapping strcpy
e38e02d 
Fixes esp8266#5949

Adds a test from the issue above and fixes the problem valgrind found.
@earlephilhower earlephilhower merged commit 9712170 into esp8266:master Apr 10, 2019
@earlephilhower earlephilhower deleted the bug5949 branch April 10, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte requested changes

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

valgrind: WString: strings overlap
3 participants
@earlephilhower @d-a-v @devyte