Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sntp_get|set_timezone_in_seconds() #5828

Merged
merged 5 commits into from
Mar 1, 2019
Merged

Implement sntp_get|set_timezone_in_seconds() #5828

merged 5 commits into from
Mar 1, 2019

Conversation

devyte
Copy link
Collaborator

@devyte devyte commented Feb 27, 2019 •
edited
Loading

Fixes #5823

@devyte
Copy link
Collaborator Author

devyte commented Feb 27, 2019

Pending after merging this:

  • export sntp_set|get_timezone_in_seconds() in a .h
  • fix cores/esp8266/time.cpp: configTime() to use sntp_set_timezone_in_seconds()

@devyte devyte self-assigned this Feb 27, 2019
@devyte devyte modified the milestones: 2.6.0, 2.5.1 Feb 27, 2019
@devyte
Fix typo
45396d2
@devyte
Fix typo
e3c2027
@devyte
Get lwip1.4 to compile
cfbc544 
This is just a workaround to get lwip1.4 to compile. It doesn't implement sntp_set_timezone_in_seconds() correctly, but rather does pretty much the same as sntp_set_timezone().
@devyte
Merge branch 'master' into timezone_in_seconds
2cb3bcc
@devyte devyte mentioned this pull request Feb 28, 2019
Closed
3 tasks
@devyte devyte merged commit 418857a into master Mar 1, 2019
@devyte devyte deleted the timezone_in_seconds branch March 5, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@devyte devyte

Labels
component: core type: enhancement
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.
1 participant
@devyte