fix DEBUG macros #5728
fix DEBUG macros #5728
Conversation
All fmt strings in flash fix esp8266#5658 This also allows to avoid warnings and easy mistakes with (no brace): if (something) DEBUGV("blah");
cores/esp8266/debug.h
Outdated
| @@ -5,11 +5,11 @@ | |||
| #include <stdint.h> | |||
|
|
|||
| #ifdef DEBUG_ESP_CORE | |||
| #define DEBUGV(...) ets_printf(__VA_ARGS__) | |||
| #define DEBUGV(fmt, ...) ::printf_P( (PGM_P)PSTR(fmt), ## __VA_ARGS__) | |||
There was a problem hiding this comment.
Should this not be the same as others (i.e. DEBUG_ESP_PORT.printf(...)?
There was a problem hiding this comment.
ets_printf is safe to call in any context (such as system), but DEBUG_ESP_PORT.printf could yield, which would not work in sys context?
There was a problem hiding this comment.
I changed to ::printf_P so we can use fmt arguments from flash.
I assume ::printf_P uses putchar installed by ets_install_putc1/putc2 in debug mode like, ets_printf does.
(should the others use ::printf_P instead of Serial.printf_P ?)
There was a problem hiding this comment.
@igrr Were you suggesting to remove (legacy) DEBUG_ESP_PORT.printf and use DEBUGV instead ?
About sys context, I believe new newlib's ::vsnprintf() and fw's ets_putc() are safe (no yield).
|
use newlib unaligned-compatible printf for DEBUGV |
|
Sorry, I thought that _write_r (which is called by printf) uses
HardwareSerial. Now I see it uses ets_putc, so indeed no issue with calling
printf from sys context.
…On Wed, Mar 13, 2019, 09:35 david gauchard ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In cores/esp8266/debug.h
<#5728 (comment)>:
> @@ -5,11 +5,11 @@
#include <stdint.h>
#ifdef DEBUG_ESP_CORE
-#define DEBUGV(...) ets_printf(__VA_ARGS__)
+#define DEBUGV(fmt, ...) ::printf_P( (PGM_P)PSTR(fmt), ## __VA_ARGS__)
@igrr <https://github.com/igrr> Were you suggesting to remove (legacy)
DEBUG_ESP_PORT.printf and use DEBUGV instead ?
About sys context, I believe new newlib's ::vsnprintf() and fw's
ets_putc() are safe (no yield).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5728 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEJcepKsBKkTrFhaYXtrm85MZzQLUjsBks5vWFXkgaJpZM4alzE->
.
|
All fmt strings in flash
fix #5658
This also allows to avoid warnings and easy mistakes with (no brace):
edit
use newlib unaligned-compatible printf for DEBUGV
fix #5855