Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LeamDNS examples #5563

Merged
merged 6 commits into from
Dec 29, 2018
Merged

Fix LeamDNS examples #5563

merged 6 commits into from
Dec 29, 2018

Conversation

hreintke
Copy link
Contributor

Fix error in esp8266 hostname update
I also added the hostname to the http response so the user sees the actual one.

@hreintke hreintke mentioned this pull request Dec 28, 2018
Closed
6 tasks
devyte
devyte approved these changes Dec 29, 2018
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@devyte devyte merged commit 62b8ac6 into esp8266:master Dec 29, 2018
@devyte devyte added this to the 2.5.0 milestone Dec 29, 2018
@hreintke
Copy link
Contributor Author

Is there a way that I can run the style checks locally before sending PR and committing to my repo ?
Then I can prevent the multiple commits.

@d-a-v
Copy link
Collaborator

d-a-v commented Dec 29, 2018

Yes, check in test/

@LaborEtArs
Copy link
Contributor

Thanks a lot 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
component: examples component: libraries type: bug
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hreintke @d-a-v @LaborEtArs @devyte