ci: fix checking CI_GITHUB_API_KEY, refactoring #5496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrr
force-pushed
the
bugfix/ci_filter_external_prs
branch
from
8898c9b
to
02558c9
Compare
CI_GITHUB_API_KEY is always set when evaluating job include/exclude conditions, and it only gets removed when the job starts. Move the check into the script.
igrr
force-pushed
the
bugfix/ci_filter_external_prs
branch
2 times, most recently
from
93a0e7c
to
31051c9
Compare
igrr
force-pushed
the
bugfix/ci_filter_external_prs
branch
from
31051c9
to
0dd5f03
Compare
igrr
changed the title
|
This PR is from a branch in a forked repo, CI passed. Also checked that CI passes for same branch in the main repo: https://travis-ci.org/esp8266/Arduino/builds/467956336 |
d-a-v
approved these changes
Dec 14, 2018
use pip3 for doc generation
install pip3
This was referenced Dec 15, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new job, build_boards, which checks that boards.txt is up to date. Previously was part of build_package job.
Move some of the jobs out of common.sh into separate scripts.
Fix checking
CI_GITHUB_API_KEY. It is always present when Travis evaluates job include/exclude conditions, and only gets removed after the job has started. Always include build_package job, and exit from it with code 0 ifCI_GITHUB_API_KEYis not present.