Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ArduinoOTA and examples with MDNS.update() calls #5494

Merged
merged 6 commits into from
Dec 14, 2018

Conversation

devyte
Copy link
Collaborator

@devyte devyte commented Dec 14, 2018

Allow use of ArduinoOTA without MDNS (meant for controlling MDNS separately)
Add MDNS.update() call in ArduinoOTA.handle()
Add MDNS.update() call in loop in all examples

@devyte
Copy link
Collaborator Author

devyte commented Dec 14, 2018

Fixes #5487 (examples)
Fixes #1297 (ArduinoOTA with no internal mdns, call begin(false))

@devyte devyte changed the title Update ArduinoOTA and examples with MDNS.update() calls WIP - Update ArduinoOTA and examples with MDNS.update() calls Dec 14, 2018
@devyte devyte merged commit e9d052c into esp8266:master Dec 14, 2018
@devyte devyte changed the title WIP - Update ArduinoOTA and examples with MDNS.update() calls Update ArduinoOTA and examples with MDNS.update() calls Dec 14, 2018
@devyte devyte deleted the ArduinoOTA branch December 14, 2018 06:37
@Swiftnesses
Copy link

Swiftnesses commented Dec 14, 2018

Hi @devyte,

Does this mean if I include ArduinoOTA, I don't need to add mDNS and include it in the loop? As a rookie I find this a little confusing (sorry).

@devyte
Copy link
Collaborator Author

devyte commented Dec 14, 2018

It does now, but only in latest git. The fix will be released with beta2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants