Keep signing commands in platform.txt on release #5491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The boards packager was deleting what was at the time it was written unused lines in fht platform.txt file before deploying to Arduino. One of these lines is now needed for signing to work, so don't delete it. Also, explicitly call "python signing.py" because it looks like Arduino is sanitizing/removing executable bits on files when extracting from boards manager installations. Fixes esp8266#5483
earlephilhower
changed the title
|
@devyte , @d-a-v , @igrr WIP because even with this change, signing fails on the Arduino boards-manager installed version. The directory structure is different vs. the git version when building, so the generated /tmp/arduino_xxx/core directory isn't even created. |
If the temporary build/core directory isn't available, make it in order that Updater.cpp will see the generated signing header and not the one in the main core.
earlephilhower
changed the title
|
WIP removed. Did manual testing by copying platform.txt and tools./signing.py of the board_package script to a board manager installed version of -b1. Signed and unsigned binaries back to good AFAICT, no more bombs in compilation. |
devyte
approved these changes
Dec 13, 2018
d-a-v
approved these changes
Dec 13, 2018
|
Just tested on a Windows install as well and it's clean. Thanks for merging overnight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The boards packager was deleting what was at the time it was written
unused lines in the platform.txt file before deploying to Arduino.
One of these lines is now needed for signing to work, so don't delete
it.
Also, explicitly call "python signing.py" because it looks like Arduino
is sanitizing/removing executable bits on files when extracting from
boards manager installations.
Fixes #5483