Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose post args during upload #4935

Merged
merged 5 commits into from
Nov 29, 2018
Merged

Expose post args during upload #4935

merged 5 commits into from
Nov 29, 2018

Conversation

luc-github
Copy link
Contributor

@luc-github luc-github commented Jul 18, 2018

Currently post args are only available at the end of upload but they are already listed - this PR just expose them with minimal changes
It also set a define for post args array size originaly set to 32
This is useful to add extra info for upload like file size or other info like file time etc...

FYR Same PR has been done to ESP32 espressif/arduino-esp32#1650

Currently post args are only available at the end of upload but they are already listed - this PR just expose them with minimal changes
It also set a define for post args array size originaly set to 32
@luc-github
Copy link
Contributor Author

luc-github commented Jul 18, 2018

I think -Werror=reorder should be part of platform.txt for flag All

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did a minor merge fix (const-ness) and reviewed the changes as I was going through it. Looks good to me. Thanks!

@earlephilhower earlephilhower merged commit 440a3aa into esp8266:master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants