-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleanup #4509
Code cleanup #4509
Conversation
FLASH_SECTOR_SIZE defined in terms of SPI_FLASH_SEC_SIZE (issue esp8266#2421).
This was a necessary include so that SPI_FLASH_SEC_SIZE can be referenced.
@fabianoms Thanks, but looks like something is still missing, because CI didn't build. Can you figure it out? |
@devyte just one check failing now. Looks like the host tests don't reference files from "tools/sdk/include/". I'm not sure if I forgot to add something in flash_utils.h or I have to edit the "Arduino/tests/host" to add some reference to sdk files. |
@fabianoms I was just looking at the same. Honestly, I'm not sure what's the best way to go here. |
TBH, i would much rather not pull the stuff defined in c_types.h into the global namespace. Easiest is probably replace all |
Closing in favor of #5327 . |
FLASH_SECTOR_SIZE defined in terms of SPI_FLASH_SEC_SIZE (issue #2421).