Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP update server can handle flash and spiffs files (spiffs size lim… #2701

Closed
wants to merge 14 commits into from
Closed

Conversation

PA4WD
Copy link
Contributor

@PA4WD PA4WD commented Nov 21, 2016

HTTP update server can handle flash and spiffs files (spiffs size limited by free space)

</form>
</body></html>)";
const char* ESP8266HTTPUpdateServer::_failedResponse = R"(Update Failed!)";
const char* ESP8266HTTPUpdateServer::_successResponse = "<META http-equiv=\"refresh\" content=\"15;URL=\">Update Success! Rebooting...";
int _command;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make the int _command a class member in ESP8266HTTPUpdateServer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PA4WD, do you need help with that?
This PR will be a great improvement to this feature!

@glynhudson
Copy link

Any update on this? It would be fantastic to be able to upload and update SPIFFS via http update server.

Thanks

@Sn4k3r
Copy link

Sn4k3r commented Apr 2, 2017

It does not work but I fixed it!
Code should be:

action='?cmd=0'
action='?cmd=100'

and

_command = _server->arg("cmd").toInt();

should be before

if(!Update.begin(maxSketchSpace, _command)){//start with max available size

See more at: http://www.esp8266.com/viewtopic.php?f=32&t=14363#sthash.fK8iDcha.dpuf

Copy link

@Sn4k3r Sn4k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code should be:

action='?cmd=0'
action='?cmd=100'

Copy link

@Sn4k3r Sn4k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_command = _server->arg("cmd").toInt();

should be before

if(!Update.begin(maxSketchSpace, _command)){//start with max available size

@PA4WD
Copy link
Contributor Author

PA4WD commented Feb 28, 2018

updated my repro,
and changed as suggested.

@d-a-v
Copy link
Collaborator

d-a-v commented Sep 20, 2019

Thanks, closed by #3732

@d-a-v d-a-v closed this Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants