Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible memory leak in MD5Builder #7195

Closed
lrodorigo opened this issue Apr 6, 2020 · 1 comment · Fixed by #7197
Closed

Possible memory leak in MD5Builder #7195

lrodorigo opened this issue Apr 6, 2020 · 1 comment · Fixed by #7197
Labels
component: core type: bug
Milestone
2.7.0

Comments

@lrodorigo
Copy link
Contributor

lrodorigo commented Apr 6, 2020 •
edited
Loading

Hi all,
I noticed a possible memory leak in MD5 Builder addStream member function.

Arduino/cores/esp8266/MD5Builder.cpp

Line 58 in eea9999

return false;

As you can see, if the readBytes fails, the function returns without freeing the allocated buffer.
@d-a-v d-a-v added this to the 2.7.0 milestone Apr 6, 2020
@earlephilhower
Copy link
Collaborator

@lrodorigo Looks like a potential leak to me! Want to do a PR for it and add the free before the return false?

lrodorigo pushed a commit to lrodorigo/Arduino-1 that referenced this issue Apr 7, 2020
@luiss-mind
Fix for MD5 leak bug, issue esp8266#7195
47cc628
@devyte devyte linked a pull request Apr 8, 2020 that will close this issue
Fix for MD5 leak bug, issue #7195 #7197
Merged
@devyte devyte removed a link to a pull request Apr 8, 2020
Fix for MD5 leak bug, issue #7195 #7197
Merged
@devyte devyte linked a pull request Apr 8, 2020 that will close this issue
Fix for MD5 leak bug, issue #7195 #7197
Merged
earlephilhower added a commit that referenced this issue Apr 9, 2020
@lrodorigo @luiss-mind
@d-a-v @devyte @earlephilhower
Fix for MD5 leak bug, issue #7195 (#7197)
41d271d 
Co-authored-by: Luiss <luiss@mind.cc>
Co-authored-by: david gauchard <gauchard@laas.fr>
Co-authored-by: Develo <deveyes@gmail.com>
Co-authored-by: Earle F. Philhower, III <earlephilhower@yahoo.com>
@lrodorigo lrodorigo mentioned this issue Apr 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: core type: bug
Projects
None yet
Milestone
2.7.0
Development

Successfully merging a pull request may close this issue.

Fix for MD5 leak bug, issue #7195 lrodorigo/Arduino-1
3 participants
@earlephilhower @d-a-v @lrodorigo