Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPClient.getString() returns payload on first call only and returns empty after #4951

Closed
hreintke opened this issue Jul 22, 2018 · 2 comments · Fixed by #5091
Closed

HTTPClient.getString() returns payload on first call only and returns empty after #4951

hreintke opened this issue Jul 22, 2018 · 2 comments · Fixed by #5091
Labels
component: libraries component: web type: bug
Milestone
2.5.0

Comments

@hreintke
Copy link
Contributor

Platform

  • Hardware: Wemos mini
  • Core Version: latest git
  • Development Env: Sloeber eclipse
  • Operating System: Windows

Settings in IDE

  • Module: Wemos D1 mini
  • Flash Size: 4MB
  • lwip Variant: v2 Lower Memory
  • Flash Frequency: 40Mhz
  • CPU Frequency: 80Mhz
  • Upload Using: SERIAL
  • Upload Speed: 921600

Problem Description

Might be working as intended but took me some time to find out when I was creating a small test program.

When the HTTPClient.GET() has finished, the payload can be retrieved with HTTPClient.getString() returns the payload.
However, when calling multiple times, only the first will return the payload, each subsequent call returns empty string.

#include "LocalDefines.h"
#include <ESP8266WiFi.h>
#include "ESP8266HTTPClient.h"

HTTPClient htpc;

void setup()
{
	Serial.begin(115200);

	Serial.printf("Initiating WiFi\r\n");
	WiFi.mode(WIFI_STA);
	Serial.printf("Wifi mode set\r\n");
    WiFi.begin(ssid,password);
    while (WiFi.status() != WL_CONNECTED) {
	    delay(1000);
	    Serial.println("Connecting to WiFi..");
	 }
	Serial.printf("IP = %s\r\n",WiFi.localIP().toString().c_str());


	htpc.begin("http:/www.google.nl");

	if (htpc.GET() > 0)
	{
		String first = htpc.getString();
		String second = htpc.getString();

		Serial.printf("------------------------------\r\n");
		Serial.printf("First len = %d, txt = %s\r\n",first.length(),first.c_str());
		Serial.printf("------------------------------\r\n");
		Serial.printf("Second len = %d, txt = %s\r\n",second.length(),second.c_str());
	}
}

void loop()
{
}

Results in Serial output.

Initiating WiFi
Wifi mode set
Connecting to WiFi..
Connecting to WiFi..
IP = 10.0.0.211
------------------------------
First len = 219, txt = <HTML><HEAD><meta http-equiv="content-type" content="text/html;charset=utf-8">
 <TITLE>301 Moved</TITLE></HEAD><BODY>
                                      <H1>301 Moved</H1>
                                                        The document has moved
                                                                              <A HREF="https://www.google.nl/">here</A>.
</BODY></HTML>

------------------------------
Second len = 0, txt =
@devyte devyte changed the title HTTPClient.getVersion() on returns payload once HTTPClient.getString() returns payload on first call only and returns empty after Jul 24, 2018
@devyte devyte added this to the 2.6.0 milestone Jul 24, 2018
@Jeroen88
Copy link
Contributor

I think this is by design, because the response is read directly from the incomming Stream, see function from ESP8266HTTPClient.cpp:

/**
 * return all payload as String (may need lot of ram or trigger out of memory!)
 * @return String
 */
String HTTPClient::getString(void)
{
    StreamString sstring;

    if(_size) {
        // try to reserve needed memmory
        if(!sstring.reserve((_size + 1))) {
            DEBUG_HTTPCLIENT("[HTTP-Client][getString] not enough memory to reserve a string! need: %d\n", (_size + 1));
            return "";
        }
    }

    writeToStream(&sstring);
    return sstring;
}

If the response is needed more than once, the sketch should use the String variable to which the payload is assigned (String first in the above example).

@hreintke
Copy link
Contributor Author

@Jeroen88 :
Yes, I have seen the implementation and that is why I mentioned

Might be working as intended ...

But normally the getter functions ( as here getString()) return the value of a Class value not only once.
-> It took me by surprise that this one did not.

@yoursunny yoursunny mentioned this issue Aug 29, 2018
Merged
yoursunny added a commit to yoursunny/ESP8266-Arduino that referenced this issue Sep 9, 2018
@yoursunny
ESP8266HTTPClient: allow getString() more than once
351ffad 
fixes esp8266#4951
devyte pushed a commit that referenced this issue Sep 9, 2018
@yoursunny @devyte
ESP8266HTTPClient: allow getString() more than once (#5091)
bbaea5a 
fixes #4951
@devyte devyte modified the milestones: 2.6.0, 2.5.0 Sep 9, 2018
d-a-v pushed a commit to d-a-v/Arduino that referenced this issue Sep 9, 2018
@yoursunny @d-a-v
ESP8266HTTPClient: allow getString() more than once (esp8266#5091)
fc96312 
fixes esp8266#4951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: libraries component: web type: bug
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

ESP8266HTTPClient: allow getString() more than once yoursunny/ESP8266-Arduino
3 participants
@hreintke @devyte @Jeroen88