Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTA completes without sending result to the client #2221

Closed
llams opened this issue Jul 4, 2016 · 6 comments
Closed

OTA completes without sending result to the client #2221

llams opened this issue Jul 4, 2016 · 6 comments
Labels
component: libraries type: bug
Milestone
2.4.0

Comments

@llams
Copy link

llams commented Jul 4, 2016 •
edited
Loading

Basic Infos

Hardware

Hardware: ESP-12F
Core Version: git master

Description

HTTP_POST Problem
Does not work the return of status after upgrading the from the library ESP8266HTTPUpdateServer.

Settings in IDE

Module: Generic ESP8266 Module

Sketch

ESP8266HTTPUpdateServer/examples/WebUpdater/
@igrr igrr changed the title HTTP_POST Problem OTA completes without sending result to the client Jul 4, 2016
@igrr igrr added this to the 2.4.0 milestone Jul 4, 2016
@igrr
Copy link
Member

igrr commented Jul 4, 2016

This looks like a regression caused by recent WiFiClient refactoring. Now that WiFiClient doesn't prevent Nagle algorithm from being used, some TCP segments may end up not being sent before restart is called.
Affects ArduinoOTA as well.

@reaper7
Copy link
Contributor

reaper7 commented Jul 4, 2016

this problem exists too on "traditional" ota upadate (2.3-latest github)
new firmware loaded to device propetrly but arduino ide still waiting for confirmation and after some time give [ERROR]: No Result!

igrr added a commit that referenced this issue May 9, 2017
@igrr
ESP8266HTTPUpdateServer: fix responses after uploading
17928b6 
- fix response not being delivered to the browser after upload is done
  (#2221)

- if Update.begin fails, don’t attempt to write data

- if update is not successful, send error message from Update to the
  client

- move strings into PROGMEM
@igrr igrr mentioned this issue May 9, 2017
Merged
@igrr
Copy link
Member

igrr commented May 9, 2017

Created #3219 to fix this

igrr added a commit that referenced this issue May 10, 2017
@igrr
ESP8266HTTPUpdateServer: fix responses after uploading
ace0622 
- fix response not being delivered to the browser after upload is done
  (#2221)

- if Update.begin fails, don’t attempt to write data

- if update is not successful, send error message from Update to the
  client

- move strings into PROGMEM
@HarmOtten
Copy link

I have a very similar issue. When uploading the example BasicOTA sketch via OTA, the new firmware is uploaded 100%, and ESP reboots, but ArduinoIDE (Running in windows7) keeps waiting.
I use ESP8266 v2.4.0-rc2 from github...

@igrr igrr closed this as completed Jan 2, 2018
@delwinbest
Copy link

I have a very similar issue. When uploading the example BasicOTA sketch via OTA, the new firmware is uploaded 100%, and ESP reboots, but ArduinoIDE (Running in windows7) keeps waiting.
I use ESP8266 v2.4.0-rc2 from github...

HarmOtten did you find the cause? I have this problem repeatedly:

20:24:27 [INFO]: Sending invitation to: 192.168.10.103
20:24:27 [INFO]: Waiting for device...
Uploading: [============================================================] 100% Done...

20:24:39 [INFO]: Waiting for result...
20:26:42 [ERROR]: No Result!

20:26:45 [INFO]: Waiting for device...
Uploading: [============================================================] 100% Done...

20:26:57 [INFO]: Waiting for result...

Where Upload size: 335056
Any ideas?

@HarmOtten
Copy link

@delwinbest,
I currently use ESP8266 v2.4.2 and I do not have the issue anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: libraries type: bug
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
5 participants
@llams @reaper7 @igrr @delwinbest @HarmOtten