Update PACs to use newly defined radio bits #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
radio_bits
branch
2 times, most recently
from
6cf8ba0 to
8b52422
Compare
bugadani
force-pushed
the
radio_bits
branch
4 times, most recently
from
7ca987b to
06fd3a8
Compare
bugadani
force-pushed
the
radio_bits
branch
2 times, most recently
from
5774b50 to
8017865
Compare
MabezDev
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
LGTM, thanks!
I merged esp-rs/esp-pacs#316 not sure if you need to change the pacs commit or not.
bjoernQ
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the regi2c_write functions of C6 and H2, by using the I2C_ANA_MST peripheral defined in the PAC.
The old C6 implementation was using the "wrong" peripheral (was using LP_I2C_ANA_MST, I guess esp-idf has changed since that point), new implementation follows https://github.com/espressif/esp-idf/blob/d30e4d9960afd0d1ed067fef741126af810f675e/components/esp_rom/patches/esp_rom_hp_regi2c_esp32c6.c
H2 implementation follows https://github.com/espressif/esp-idf/blob/d30e4d9960afd0d1ed067fef741126af810f675e/components/esp_rom/patches/esp_rom_regi2c_esp32h2.c
The rest of the chips received a bit of a touchup as well, though nothing major.
PAC PR: esp-rs/esp-pacs#316