Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify traits and erratum 36 workaround, add Pins::steal #2335

Merged
merged 9 commits into from
Oct 18, 2024
Merged

Simplify traits and erratum 36 workaround, add Pins::steal #2335

merged 9 commits into from
Oct 18, 2024

Conversation

bugadani
Copy link
Contributor

No description provided.

@bugadani bugadani added the skip-changelog No changelog modification needed label Oct 10, 2024
@bugadani bugadani changed the title Simplify erratum 36 Simplify erratum 36 workaround Oct 10, 2024
@bugadani bugadani changed the title Simplify erratum 36 workaround Simplify erratum 36 workaround, add Pins::steal Oct 10, 2024
@bugadani bugadani removed the skip-changelog No changelog modification needed label Oct 10, 2024
@bugadani bugadani force-pushed the erratum branch 2 times, most recently from b01f0a5 to 90026da Compare October 10, 2024 20:37
@bugadani bugadani changed the title Simplify erratum 36 workaround, add Pins::steal Simplify traits and erratum 36 workaround, add Pins::steal Oct 10, 2024
bjoernQ
bjoernQ approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now set rue/rde also for pins unaffected by errata 3.6 - I guess that's not a problem?

@bugadani
Copy link
Contributor Author

I believe the other pins don't have rue/rde. That part isn't a problem, the problem is that this will panic... Back to the drawing board.

@bugadani bugadani marked this pull request as draft October 11, 2024 07:08
@bugadani bugadani marked this pull request as ready for review October 11, 2024 07:43
@bugadani bugadani force-pushed the erratum branch 3 times, most recently from 1c58871 to dee1361 Compare October 16, 2024 13:54
@bugadani bugadani mentioned this pull request Oct 16, 2024
Merged
6 tasks
MabezDev
MabezDev approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MabezDev MabezDev enabled auto-merge October 18, 2024 14:10
@MabezDev MabezDev added this pull request to the merge queue Oct 18, 2024
Merged via the queue into esp-rs:main with commit d32a733 Oct 18, 2024
25 of 28 checks passed
@bugadani bugadani deleted the erratum branch October 18, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugadani @bjoernQ @MabezDev