Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence clippy #2332

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Silence clippy #2332

merged 1 commit into from
Oct 11, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Oct 10, 2024 •
edited
Loading

I'm not entirely sure why this only errors locally and not in CI, the lint is suppoosed to exist since rust 1.34.

@bugadani bugadani added the skip-changelog No changelog modification needed label Oct 10, 2024
SergioGasquez
SergioGasquez approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bugadani bugadani added this pull request to the merge queue Oct 11, 2024
Merged via the queue into esp-rs:main with commit 7aa8145 Oct 11, 2024
29 checks passed
@bugadani bugadani deleted the warning branch October 11, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugadani @bjoernQ @SergioGasquez