Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mindless SPI slave cleanup #2266

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Mindless SPI slave cleanup #2266

merged 1 commit into from
Oct 3, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Oct 2, 2024

No description provided.

@bugadani bugadani added the skip-changelog No changelog modification needed label Oct 2, 2024
Dominaezzz
Dominaezzz approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@Dominaezzz Dominaezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM

jessebraham
jessebraham approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jessebraham jessebraham added this pull request to the merge queue Oct 3, 2024
Merged via the queue into esp-rs:main with commit e033162 Oct 3, 2024
29 checks passed
@bugadani bugadani deleted the spis branch October 3, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

@Dominaezzz Dominaezzz Dominaezzz approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugadani @jessebraham @Dominaezzz