Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable problematic ESP32 test #2185

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Disable problematic ESP32 test #2185

merged 1 commit into from
Sep 18, 2024

Conversation

bugadani
Copy link
Contributor

I hate blocking other stuff and this broke somewhere. I'll investigate, but let's unblock CI meanwhile.

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good call. Would you mind updating #1524 if you haven't already too, please?

@bugadani
Copy link
Contributor Author

I'd rather not, we'll never close that issue and the list just turns into a mess eventually.

@MabezDev
Copy link
Member

I thought we didn't have required checks on HIL tests, so is it actually blocking anything?

If we're not going to update the issue, I'd rather this stayed failing so we have a reason to fix it.

@bugadani
Copy link
Contributor Author

bugadani commented Sep 18, 2024

I thought we didn't have required checks on HIL tests, so is it actually blocking anything?

It's not required but it looks bad :)

If we're not going to update the issue, I'd rather this stayed failing so we have a reason to fix it.

I've opened a new issue and linked it in the tracking.

@bjoernQ bjoernQ added this pull request to the merge queue Sep 18, 2024
Merged via the queue into esp-rs:main with commit b1ca30e Sep 18, 2024
27 checks passed
@bugadani bugadani deleted the esp32 branch September 18, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants