-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix known SPI issues #2179
Fix known SPI issues #2179
Conversation
d4fc3dd
to
a5ea086
Compare
Ah finally CI reproduces my local issues with ESP32. Fun! |
69356e8
to
8dd71f3
Compare
844ae3e
to
b7b220a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I solemnly wov that the ESP32 tests pass locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bugadani Sounds good 😁 Changes LGTM, thanks!
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
Changes include:
is_done
inwait
to actually wait for the DMA to finish transferring from SPI to memory. This prevents weird test failures where an assert fails, then prints that the buffer and the expected value match.dma_transfer
Fixes #2098
Fixes #2186
Testing
yes