Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SPI_DMA_XX_ASYNC and _PCNT tests on ESP32 and S2, remove GPIO … #2140

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

JurajSadel
Copy link
Contributor

…usage from description

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

spi_full_duplex_dma_async and spi_full_duplex_dma_pcnt didn't work on ESP32 and S2 - with #2131 merged, tests start passing.
Removed the GPIO usage from test description.

Not sure if we can tick the tests in #1524 because of #2098,

Testing

Ran HIL tests on ESP32 locally (for some reason my S2+PROG doesn't work - can't flash any test)

@JurajSadel JurajSadel added the skip-changelog No changelog modification needed label Sep 11, 2024
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@bugadani bugadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to see these go, thank you

@bugadani bugadani added this pull request to the merge queue Sep 11, 2024
Merged via the queue into esp-rs:main with commit f374d6a Sep 11, 2024
28 checks passed
@JurajSadel JurajSadel deleted the hil/upd branch September 11, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants