Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pin drivers as wakeup sources #2095

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Allow pin drivers as wakeup sources #2095

merged 2 commits into from
Sep 9, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Sep 5, 2024

Closes #2020

@bugadani bugadani force-pushed the rtc branch 2 times, most recently from 046eba5 to 71e305f Compare September 5, 2024 17:21

#[doc(hidden)]
#[macro_export]
macro_rules! handle_rtcio {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next up, how can I delete these... I'm hoping there is a solution that allows me to factor this as a repeat_erased! and a filter_branches! macro, but I haven't tried anything yet.

@bugadani bugadani force-pushed the rtc branch 3 times, most recently from d0a9b43 to 38abd6e Compare September 5, 2024 18:06
#[cfg(any(xtensa, esp32c2, esp32c3, esp32c6))]
impl RtcPin for ErasedPin {
#[cfg(xtensa)]
#[allow(unused_braces)] // False positive :/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bugadani bugadani marked this pull request as ready for review September 6, 2024 10:53
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - makes things more convenient!

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev enabled auto-merge September 9, 2024 10:21
@MabezDev MabezDev added this pull request to the merge queue Sep 9, 2024
Merged via the queue into esp-rs:main with commit be82a65 Sep 9, 2024
27 checks passed
@bugadani bugadani deleted the rtc branch September 9, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Used GPIOs can't be unconfigured for wakeup
3 participants