Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lcd_cam: i8080 fix bad len calculation (missed from ReadBuffer update) #1876

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

liebman
Copy link
Contributor

@liebman liebman commented Jul 29, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

PR #1834 mised a change related to ReadBuffer in send_dma_async and as a result computes the len as twice the size it should be for 16bit.

Description

No need to multiply the len returned by ReadBuffer::read_buffer()

Testing

Local hub75 implementation.

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bjoernQ bjoernQ added the skip-changelog No changelog modification needed label Jul 29, 2024
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JurajSadel JurajSadel enabled auto-merge July 29, 2024 15:07
@JurajSadel JurajSadel added this pull request to the merge queue Jul 29, 2024
Merged via the queue into esp-rs:main with commit dd2e475 Jul 29, 2024
18 of 19 checks passed
@liebman liebman deleted the i8080-async-size-fix branch July 29, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants