Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generator version #67

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Generator version #67

merged 3 commits into from
Dec 17, 2024

Conversation

bjoernQ
Copy link
Collaborator

@bjoernQ bjoernQ commented Dec 13, 2024

  • include version of esp-generate in the generated code
  • use rustc-link-arg instead of rustc-link-arg-bin

SergioGasquez
SergioGasquez approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@SergioGasquez SergioGasquez added this pull request to the merge queue Dec 17, 2024
Merged via the queue into esp-rs:main with commit db917b7 Dec 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernQ @SergioGasquez