Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bin section #62

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Add bin section #62

merged 5 commits into from
Nov 28, 2024

Conversation

SergioGasquez
Copy link
Member

With this change the generated bin will have the project name instead of main, this helps with using esp-template in Wokwi

@bjoernQ
Copy link
Collaborator

bjoernQ commented Nov 28, 2024

I don't know much about Wokwi but

elf = "target/{{ rust_target }}/debug/{{ project-name }}"
firmware = "target/{{ rust_target }}/debug/{{ project-name }}"

shouldn't it use release there?

I also thought about a improving the INCLUDEFILE functionality to support renaming the target file - might also work if we always name it main.rs?

@SergioGasquez
Copy link
Member Author

shouldn't it use release there?

I think its useful to use debug as Wokwi is used, many times, to debug. But no hard opinion here.

TBH, I didnt noticed that wowki.toml was not working, this PR should also fix it. By making Wokwi things simpler, I meant the wokwi-builders we use for Wokwi web version

Copy link
Collaborator

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bjoernQ bjoernQ enabled auto-merge November 28, 2024 12:00
@bjoernQ bjoernQ added this pull request to the merge queue Nov 28, 2024
Merged via the queue into esp-rs:main with commit 252262e Nov 28, 2024
10 checks passed
@SergioGasquez SergioGasquez deleted the feat/bin branch November 28, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants