Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ChangeBaudrate processing #50

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Update ChangeBaudrate processing #50

merged 1 commit into from
Mar 5, 2024

Conversation

SergioGasquez
Copy link
Member

Change the way we process ChangeBaudrate commands:

  • Increased the delay after sending the response
  • Remove sending the greeting: C stubs don't do this
  • Added a small delay after changing the baudrate to imitate the C stubs

PR is open against the esp-hal-upgrade branch which is the one I used for testing.

@SergioGasquez SergioGasquez linked an issue Mar 5, 2024 that may be closed by this pull request
Flashing an S3 with baud rate higher than 115,200 causes a timeout #49
Closed
JurajSadel
JurajSadel approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

MabezDev
MabezDev approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MabezDev MabezDev merged commit cdb1a67 into esp-rs:esp-hal-upgrade Mar 5, 2024
@SergioGasquez SergioGasquez deleted the fix/change-baud branch March 5, 2024 11:51
MabezDev added a commit that referenced this pull request Mar 8, 2024
@MabezDev @SergioGasquez
Update to esp-hal unified, read => read_volatile on uart fifo (#48)
e9b6129 
* Update to esp-hal unified, read => read_volatile on uart fifo

* feat: Update ChangeBaudrate processing (#50)

* feat: Bump MSRV (#51)

* use released hal

---------

Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
@MabezDev MabezDev mentioned this pull request Apr 24, 2024
Open
@SergioGasquez SergioGasquez mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

@JurajSadel JurajSadel JurajSadel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flashing an S3 with baud rate higher than 115,200 causes a timeout
3 participants
@SergioGasquez @MabezDev @JurajSadel