Skip to content

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Nov 8, 2023

Description

  • Refactor code to make the main code cleaner by adding a new using DisplayDriver = ... into each device header
  • Add box_3.hpp and associated BOX-3 configuration to main code and Kconfig for box 3 support
  • Update espp submodule to support unified touch interfaces and driver updates.

Motivation and Context

Supporting more (and newer) hardware is nice, and the ESP32-S3-BOX-3 is nice :)

How has this been tested?

Running on:

  • LilyGo T-Deck
  • ESP32-S3-BOX
  • ESP32-S3-BOX-3

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

…ay and touch do not seem to work, and the touch drivers are not recognized on the bus at all :/
@finger563 finger563 marked this pull request as draft November 8, 2023 15:02
@finger563 finger563 changed the title feat(box3): simplified code and working on adding box3 support (displ… Simplify code and add support for ESP32-S3-BOX-3 Nov 8, 2023
@finger563 finger563 self-assigned this Nov 8, 2023
@finger563 finger563 marked this pull request as ready for review November 8, 2023 15:49
@finger563 finger563 added enhancement New feature or request box-3 labels Nov 8, 2023
@finger563 finger563 merged commit c4643f7 into main Nov 8, 2023
@finger563 finger563 deleted the feature/box-3-support branch November 8, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
box-3 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant