Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cygwin build configuration and code switches #149

Conversation

theurich
Copy link
Member

@theurich theurich commented Jun 13, 2023

Start the review process of changes provided by @robin-deltares.

See the associated issue: #136

This PR needs very careful review. A lot of source files have been touched. Best to work on this when having access to a Cygwin system.

@DWesl
Copy link
Collaborator

DWesl commented Nov 21, 2023

You could use GitHub Actions to get a Cygwin installation, I have an example here: https://github.com/DWesl/esmf/tree/esmf-cygwin-compile
It takes two hours to compile and one to run the checks, roughly the same as on a laptop. It is a bit more difficult to work out which flags guard various definitions (for example, math.h defines M_PI if you pass -D_BSD_SOURCE on the command line).

The doc build isn't working at the moment, and I'm not sure how to fix that.

@theurich theurich deleted the branch esmf-org:fix/cygwin May 13, 2024 22:31
@theurich theurich closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants