ISSUE-76: Fixes Nominatim, implements better S3 fetching for non cached files #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on a SBF module pull to be made later today
Same way we use in the webform module, not elegant, but functional to get around the IP address/session changes in a dev environment/docker exposed IPs when calling Exposed Routes directly
DiegoPino
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #76
Calls nominatim by faking an HTTP request instead of making one actually allowing us to escape the fact that there are domain changes in a test environment and that session keys/tokens do not match when that happens/nominatim is protected.
This requires esmero/strawberryfield#216