ISSUE-100 and ISSUE-99: Fixes PHP8 issues (general) #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gets around the fact that people might pass into a CSV data that needs to be an array but is empty (string, etc)
Need to ask @alliomeria / @karomabiles about what to expect when "updating" a published entity and passing a new "draft state". Because what will happen now (which is correct but annoying bc of workflows) is that the published one will stay as it was and a new revision (draft) will be added but not enabled yet. Which can be then "made" published via Content/publish action. But it might need documentation?
DiegoPino
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #99 and #100
This also adds some AMI improvements for Updates when the source data from the CSV is lacking structure badly. I will have to iterate over and over this reality a few times but I feel I got it this time