Data Request #29
Merged
Data Request #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This currently implements the same logic as in the Ruby tool. |
…elevant for pymorize
…e is requested for both average and instant
|
There are two last things here that I would be happy for @siligam to look at:
Otherwise this is good to go and duplicates the Ruby logic. To what extent and how we use this is not yet decided. |
…fined in a single place
|
OK, this one is good to go from my side. Please review and make suggestions for improvements. |
|
God mode used for this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will provide functionality to merge together various Tables/Data Requests and connect it so that one Rule has all information linked to a specific Data Request Variable.
Will close #18