Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate output time ranges #15

Closed
mandresm opened this issue Jul 1, 2024 · 0 comments · Fixed by #21
Closed

Calculate output time ranges #15

mandresm opened this issue Jul 1, 2024 · 0 comments · Fixed by #21
Assignees
Labels
backend old feature Features of the old SEAMORE Ruby Implementation
Milestone

Comments

@mandresm
Copy link
Contributor

mandresm commented Jul 1, 2024

Calculates year ranges for the output (https://github.com/FESOM/seamore/blob/7725366f7b68ea3824ac6baa500ea49531722b72/lib/cmorizer.rb#L182-L195)

This range calculation is not straight forward as we do not only specify the first and last year, and the step of the output, but we also specify the major_first_digit, so in which precise year we are storing a range. That means our first output file can have a different time range as the following ones. For example:

first: 2023
last: 2051
majort_first_digit: 1
step: 10

In the case above the following files labelled with the year key should cover the values time spans:

2031: 2023-2030
2041: 2031-2040
2051: 2041-2050

It does something similar if the stepping exceeds the last bound.

I am wondering... is this extra complicated logic really necessary? --> ask Christopher

Limitations:

  • The way it is coded limits us to year ranges, we cannot specify monthly ranges for the output files, which might be a problem for the future high resolution simulations (we should write it first for years, but do it in a way that is easier to generalise to months)

Called by:

Calls: range_years

@mandresm mandresm added backend old feature Features of the old SEAMORE Ruby Implementation labels Jul 1, 2024
@pgierz pgierz self-assigned this Jul 17, 2024
@pgierz pgierz linked a pull request Jul 17, 2024 that will close this issue
@pgierz pgierz mentioned this issue Jul 17, 2024
pgierz added a commit that referenced this issue Jul 17, 2024
@pgierz pgierz added this to the Beta Release milestone Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend old feature Features of the old SEAMORE Ruby Implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants