Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Breaking Change to lots of AST node types for TypeScript constructs #386

Closed
JamesHenry opened this issue Sep 25, 2017 · 3 comments
Closed

Breaking Change to lots of AST node types for TypeScript constructs #386

JamesHenry opened this issue Sep 25, 2017 · 3 comments
Assignees
@JamesHenry

Comments

@JamesHenry
Copy link
Member

Follow up to babel/babylon#710

cc @soda0289 @azz @weirdpattern

I should hopefully get to this this week.
@JamesHenry JamesHenry mentioned this issue Sep 25, 2017
Merged
@JamesHenry
Copy link
Member Author

Just in case anybody else looks at this, be sure to run:

yarn ast-alignment-tests

It will run the comparisons between Babylon and typescript-eslint-parser

@hzoo
Copy link
Member

hzoo commented Sep 25, 2017

Should just be 4 based on babel/babel#6306,

TypeParameter
TypeParameterInstantiation
TypeParameterDeclaration
TypeParameter

@JamesHenry
Copy link
Member Author

Actually I'll work on this now

JamesHenry added a commit that referenced this issue Sep 25, 2017
@JamesHenry
Breaking: Updates to AST node types of some TSNodes (fixes #386)
6f3f5f4
JamesHenry added a commit that referenced this issue Sep 25, 2017
@JamesHenry
Breaking: Updates to AST node types of some TSNodes (fixes #386)
fbb98c4
@JamesHenry JamesHenry mentioned this issue Sep 25, 2017
Closed
@JamesHenry JamesHenry self-assigned this Oct 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JamesHenry JamesHenry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hzoo @JamesHenry