chore: Add .ts files to lint-staged #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -20,7 +20,7 @@ | |||
| "pre-commit": "lint-staged" | |||
| }, | |||
| "lint-staged": { | |||
| "*.js": [ | |||
| "*.{js|ts}": [ | |||
There was a problem hiding this comment.
Line 27 in c3fea62
We also have this where we run prettier? Does that mean for .ts prettier will run twice now?
There was a problem hiding this comment.
Yes.
I think this PR change may be unnecessary since we're already linting .ts files.
Ref #22 (comment)
There was a problem hiding this comment.
Good catch! Added .ts to the second entry to ensure it won't be run through prettier twice.
There was a problem hiding this comment.
Added
.tsto the second entry to ensure it won't be run through prettier twice.
Maybe this change isn't pushed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Ensure
.tsfiles are linted on precommitWhat changes did you make? (Give an overview)
.tsfiles to thelint-stagedconfig inpackage.jsonRelated Issues
Is there anything you'd like reviewers to focus on?