Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check upper bounds of message line numbers for code blocks #247

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

DMartens
Copy link
Contributor

Fixes #244.
Added an upper guard to make sure the access to block.rangeMap[lineNumber] is defined as well as add a simple test case (I manually set the state via preprocess in the test case and not use the "shared" state from the beforeEach to make this test case clearer).

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. Can you check the linting error?

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit 00adccb into eslint:main Apr 1, 2024
10 checks passed
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 22, 2024
##### [v5.1.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#510-2024-07-05)

##### Features

-   add name to flat configs ([#256](eslint/markdown#256)) ([001d51e](eslint/markdown@001d51e))
##### [v5.0.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#500-2024-05-01)

##### ⚠ BREAKING CHANGES

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246))

##### Features

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246)) ([096cff4](eslint/markdown@096cff4))

##### Bug Fixes

-   check upper bounds of message line numbers for code blocks ([#247](eslint/markdown#247)) ([00adccb](eslint/markdown@00adccb))

##### Chores

-   run tests in Node.js 22, with ESLint 9 ([#250](eslint/markdown#250)) ([085e6d5](eslint/markdown@085e6d5))
-   switch to eslint v9, eslint-config-eslint v10 ([#251](eslint/markdown#251)) ([a76cdf5](eslint/markdown@a76cdf5))
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 22, 2024
##### [v5.1.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#510-2024-07-05)

##### Features

-   add name to flat configs ([#256](eslint/markdown#256)) ([001d51e](eslint/markdown@001d51e))
##### [v5.0.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#500-2024-05-01)

##### ⚠ BREAKING CHANGES

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246))

##### Features

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246)) ([096cff4](eslint/markdown@096cff4))

##### Bug Fixes

-   check upper bounds of message line numbers for code blocks ([#247](eslint/markdown#247)) ([00adccb](eslint/markdown@00adccb))

##### Chores

-   run tests in Node.js 22, with ESLint 9 ([#250](eslint/markdown#250)) ([085e6d5](eslint/markdown@085e6d5))
-   switch to eslint v9, eslint-config-eslint v10 ([#251](eslint/markdown#251)) ([a76cdf5](eslint/markdown@a76cdf5))
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 22, 2024
##### [v5.1.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#510-2024-07-05)

##### Features

-   add name to flat configs ([#256](eslint/markdown#256)) ([001d51e](eslint/markdown@001d51e))
##### [v5.0.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#500-2024-05-01)

##### ⚠ BREAKING CHANGES

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246))

##### Features

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246)) ([096cff4](eslint/markdown@096cff4))

##### Bug Fixes

-   check upper bounds of message line numbers for code blocks ([#247](eslint/markdown#247)) ([00adccb](eslint/markdown@00adccb))

##### Chores

-   run tests in Node.js 22, with ESLint 9 ([#250](eslint/markdown#250)) ([085e6d5](eslint/markdown@085e6d5))
-   switch to eslint v9, eslint-config-eslint v10 ([#251](eslint/markdown#251)) ([a76cdf5](eslint/markdown@a76cdf5))
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 22, 2024
##### [v5.1.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#510-2024-07-05)

##### Features

-   add name to flat configs ([#256](eslint/markdown#256)) ([001d51e](eslint/markdown@001d51e))
##### [v5.0.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#500-2024-05-01)

##### ⚠ BREAKING CHANGES

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246))

##### Features

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246)) ([096cff4](eslint/markdown@096cff4))

##### Bug Fixes

-   check upper bounds of message line numbers for code blocks ([#247](eslint/markdown#247)) ([00adccb](eslint/markdown@00adccb))

##### Chores

-   run tests in Node.js 22, with ESLint 9 ([#250](eslint/markdown#250)) ([085e6d5](eslint/markdown@085e6d5))
-   switch to eslint v9, eslint-config-eslint v10 ([#251](eslint/markdown#251)) ([a76cdf5](eslint/markdown@a76cdf5))
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 23, 2024
##### [v5.1.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#510-2024-07-05)

##### Features

-   add name to flat configs ([#256](eslint/markdown#256)) ([001d51e](eslint/markdown@001d51e))
##### [v5.0.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#500-2024-05-01)

##### ⚠ BREAKING CHANGES

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246))

##### Features

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246)) ([096cff4](eslint/markdown@096cff4))

##### Bug Fixes

-   check upper bounds of message line numbers for code blocks ([#247](eslint/markdown#247)) ([00adccb](eslint/markdown@00adccb))

##### Chores

-   run tests in Node.js 22, with ESLint 9 ([#250](eslint/markdown#250)) ([085e6d5](eslint/markdown@085e6d5))
-   switch to eslint v9, eslint-config-eslint v10 ([#251](eslint/markdown#251)) ([a76cdf5](eslint/markdown@a76cdf5))
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 23, 2024
##### [v5.1.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#510-2024-07-05)

##### Features

-   add name to flat configs ([#256](eslint/markdown#256)) ([001d51e](eslint/markdown@001d51e))
##### [v5.0.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#500-2024-05-01)

##### ⚠ BREAKING CHANGES

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246))

##### Features

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246)) ([096cff4](eslint/markdown@096cff4))

##### Bug Fixes

-   check upper bounds of message line numbers for code blocks ([#247](eslint/markdown#247)) ([00adccb](eslint/markdown@00adccb))

##### Chores

-   run tests in Node.js 22, with ESLint 9 ([#250](eslint/markdown#250)) ([085e6d5](eslint/markdown@085e6d5))
-   switch to eslint v9, eslint-config-eslint v10 ([#251](eslint/markdown#251)) ([a76cdf5](eslint/markdown@a76cdf5))
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 23, 2024
##### [v5.1.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#510-2024-07-05)

##### Features

-   add name to flat configs ([#256](eslint/markdown#256)) ([001d51e](eslint/markdown@001d51e))
##### [v5.0.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#500-2024-05-01)

##### ⚠ BREAKING CHANGES

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246))

##### Features

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246)) ([096cff4](eslint/markdown@096cff4))

##### Bug Fixes

-   check upper bounds of message line numbers for code blocks ([#247](eslint/markdown#247)) ([00adccb](eslint/markdown@00adccb))

##### Chores

-   run tests in Node.js 22, with ESLint 9 ([#250](eslint/markdown#250)) ([085e6d5](eslint/markdown@085e6d5))
-   switch to eslint v9, eslint-config-eslint v10 ([#251](eslint/markdown#251)) ([a76cdf5](eslint/markdown@a76cdf5))
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 23, 2024
##### [v5.1.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#510-2024-07-05)

##### Features

-   add name to flat configs ([#256](eslint/markdown#256)) ([001d51e](eslint/markdown@001d51e))
##### [v5.0.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#500-2024-05-01)

##### ⚠ BREAKING CHANGES

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246))

##### Features

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246)) ([096cff4](eslint/markdown@096cff4))

##### Bug Fixes

-   check upper bounds of message line numbers for code blocks ([#247](eslint/markdown#247)) ([00adccb](eslint/markdown@00adccb))

##### Chores

-   run tests in Node.js 22, with ESLint 9 ([#250](eslint/markdown#250)) ([085e6d5](eslint/markdown@085e6d5))
-   switch to eslint v9, eslint-config-eslint v10 ([#251](eslint/markdown#251)) ([a76cdf5](eslint/markdown@a76cdf5))
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 23, 2024
##### [v5.1.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#510-2024-07-05)

##### Features

-   add name to flat configs ([#256](eslint/markdown#256)) ([001d51e](eslint/markdown@001d51e))
##### [v5.0.0](https://github.com/eslint/eslint-plugin-markdown/blob/HEAD/CHANGELOG.md#500-2024-05-01)

##### ⚠ BREAKING CHANGES

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246))

##### Features

-   map known code block languages to respective file extensions ([#246](eslint/markdown#246)) ([096cff4](eslint/markdown@096cff4))

##### Bug Fixes

-   check upper bounds of message line numbers for code blocks ([#247](eslint/markdown#247)) ([00adccb](eslint/markdown@00adccb))

##### Chores

-   run tests in Node.js 22, with ESLint 9 ([#250](eslint/markdown#250)) ([085e6d5](eslint/markdown@085e6d5))
-   switch to eslint v9, eslint-config-eslint v10 ([#251](eslint/markdown#251)) ([a76cdf5](eslint/markdown@a76cdf5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Uncaught undefined for reporting after a code block
2 participants