Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Specify default values of options (fixes #325) #342

Merged
merged 2 commits into from
Jun 20, 2017
Merged

Docs: Specify default values of options (fixes #325) #342

merged 2 commits into from
Jun 20, 2017

Conversation

Hirse
Copy link
Contributor

@Hirse Hirse commented Jun 19, 2017

@kaicataldo how does this look for you?

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nitpick, but otherwise LGTM. Thanks for contributing!

README.md Outdated

// set to 3, 5 (default), 6, 7, or 8 to specify the version of ECMAScript syntax you want to use.
// You can also set to 2015 (same as 6), 2016 (same as 7), or 2017 (same as 8) to use the year-based naming.
// set to 3, 5, 6, 7, or 8 to specify the version of ECMAScript syntax you want to use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity, can we make both of these sentences (Captialize set and put periods at the end of each comment)

@kaicataldo kaicataldo merged commit 16e1fec into eslint:master Jun 20, 2017
@kaicataldo
Copy link
Member

Thanks for contributing!

@Hirse Hirse deleted the default-values branch June 21, 2017 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants