Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: handle --output-file for empty output when saving to disk #17957

Merged
merged 4 commits into from
Jan 6, 2024

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fixes #17660

Is there anything you'd like reviewers to focus on?

No

@snitin315 snitin315 requested a review from a team as a code owner January 5, 2024 02:24
@eslint-github-bot eslint-github-bot bot added breaking This change is backwards-incompatible bug ESLint is working incorrectly labels Jan 5, 2024
Copy link

netlify bot commented Jan 5, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 08db74f
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6598bf2e3aea2f0008e4034b
😎 Deploy Preview https://deploy-preview-17957--docs-eslint.netlify.app/use/migrate-to-9.0.0
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@snitin315 snitin315 added cli Relates to ESLint's command-line interface accepted There is consensus among the team that this change meets the criteria for inclusion labels Jan 5, 2024
snitin315 and others added 2 commits January 6, 2024 08:15
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic changed the title fix!: handle -output-file for empty output when saving to disk fix!: handle --output-file for empty output when saving to disk Jan 6, 2024
@mdjermanovic mdjermanovic merged commit bde5105 into main Jan 6, 2024
17 checks passed
@mdjermanovic mdjermanovic deleted the output-empty-file branch January 6, 2024 18:22
bmish added a commit to bmish/eslint that referenced this pull request Jan 16, 2024
* main:
  chore: Split Docs CI from core CI (eslint#17897)
  fix: Ensure config keys are printed for config errors (eslint#17980)
  chore: delete relative-module-resolver.js (eslint#17981)
  docs: migration guide entry for `no-inner-declarations` (eslint#17977)
  docs: Update README
  feat: maintain latest ecma version in ESLint (eslint#17958)
  feat!: no-inner-declaration new default behaviour and option (eslint#17885)
  feat: add `no-useless-assignment` rule (eslint#17625)
  fix: `no-misleading-character-class` edge cases with granular errors (eslint#17970)
  feat: `no-misleading-character-class` granular errors (eslint#17515)
  docs: fix number of code-path events on custom rules page (eslint#17969)
  docs: reorder entries in v9 migration guide (eslint#17967)
  fix!: handle `--output-file` for empty output when saving to disk (eslint#17957)
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jul 5, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible bug ESLint is working incorrectly cli Relates to ESLint's command-line interface
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bug: --output-file not written when empty
2 participants