Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Update: add missing JSXOpeningFragment and JSXClosingFragment #33

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

flyerhzm
Copy link
Contributor

@flyerhzm flyerhzm commented Dec 25, 2021

This PR adds missing JSXOpeningFragment and JSXClosingFragment.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 25, 2021

CLA Signed

The committers are authorized under a signed CLA.

@eslint-github-bot
Copy link

Hi @flyerhzm!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

@flyerhzm flyerhzm changed the title add missing JSXOpeningFragment and JSXClosingFragment Update: add missing JSXOpeningFragment and JSXClosingFragment Dec 25, 2021
@eslint-github-bot
Copy link

Hi @flyerhzm!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

1 similar comment
@eslint-github-bot
Copy link

Hi @flyerhzm!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

@nzakas
Copy link
Member

nzakas commented Dec 28, 2021

Thanks @flyerhzm. Can you please sign the CLA? (See previous comment)

@flyerhzm
Copy link
Contributor Author

flyerhzm commented Jan 2, 2022

@nzakas done signing

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Commit message should be fixed on merging. I think this should be feat.

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants