Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected top-level property "name" with ESLint 8 #489

Closed
jhnns opened this issue Jul 19, 2024 · 1 comment · Fixed by #490 or qdraw/starsky#1686 · May be fixed by nodeshift/openshift-rest-client#427, nodeshift/openshift-rest-client#428 or WontonSam/cachimanexpress.js-Design-Patterns-Third-Edition#588
Closed

Unexpected top-level property "name" with ESLint 8 #489

jhnns opened this issue Jul 19, 2024 · 1 comment · Fixed by #490 or qdraw/starsky#1686 · May be fixed by nodeshift/openshift-rest-client#427, nodeshift/openshift-rest-client#428 or WontonSam/cachimanexpress.js-Design-Patterns-Third-Edition#588
Labels
released

Comments

@jhnns
Copy link

jhnns commented Jul 19, 2024

Description

ca9e9b4 introduced a name property on the recommended configs. ESLint 8, however, will throw the following error because of the unknown property:

ESLint: 8.57.0

Error: ESLint configuration in .eslintrc.json » ../../base.js » plugin:promise/recommended is invalid:
	- Unexpected top-level property "name".

Steps to Reproduce

  1. Use recommended config with ESLint 8 and legacy config format (not sure if it's also an issue with flat configs)

Expected behavior: The plugin should work with ESLint 8 as it's still listed in the peerDependencies

Actual behavior: It throws

Versions

  • Node version: 22.3.0
  • ESLint version: 8.57.0
  • eslint-plugin-promise version: 6.5.0
brettz9 added a commit to brettz9/eslint-plugin-promise that referenced this issue Jul 19, 2024
@brettz9
fix: remove name from eslintrc config; fixes eslint-community#489
5bd794c
@brettz9 brettz9 mentioned this issue Jul 19, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

🎉 This issue has been resolved in version 6.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Jul 27, 2024
Closed
Closed
@w3nl w3nl mentioned this issue Aug 10, 2024
Closed
This was referenced Aug 11, 2024
Closed
Open
Closed
Open
Closed
Closed
@w3nl w3nl mentioned this issue Aug 19, 2024
Closed
@rsaz rsaz mentioned this issue Aug 24, 2024
Closed
@lholmquist lholmquist mentioned this issue Aug 28, 2024
Closed
@qdraw qdraw mentioned this issue Sep 1, 2024
Merged
@WontonSam WontonSam mentioned this issue Oct 5, 2024
Open
@MaxMood96 MaxMood96 mentioned this issue Oct 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove name from eslintrc config; fixes #489 brettz9/eslint-plugin-promise
[Snyk] Upgrade eslint-plugin-promise from 6.2.0 to 6.6.0 qdraw/starsky
[Snyk] Upgrade eslint-plugin-promise from 6.2.0 to 6.5.1 nodeshift/openshift-rest-client
[Snyk] Upgrade eslint-plugin-promise from 6.2.0 to 6.6.0 nodeshift/openshift-rest-client
[Snyk] Upgrade eslint-plugin-promise from 4.2.1 to 7.1.0 WontonSam/cachimanexpress.js-Design-Patterns-Third-Edition
[Snyk] Upgrade eslint-plugin-promise from 6.1.1 to 6.6.0 MaxMood96/nock
[Snyk] Upgrade eslint-plugin-promise from 6.4.0 to 6.5.1 trojs/openapi-dereference
[Snyk] Upgrade eslint-plugin-promise from 6.4.0 to 6.5.1 nodeshift/kube-service-bindings
[Snyk] Upgrade eslint-plugin-promise from 6.4.0 to 6.6.0 nodeshift/kube-service-bindings
[Snyk] Upgrade eslint-plugin-promise from 6.5.0 to 6.6.0 nodeshift/kube-service-bindings
1 participant
@jhnns