fix(prefer-await-to-then):member access without call (#362)

eslint-community · Sep 29, 2022 · 9b3ef57 · 9b3ef57
1 parent 08052e8
commit 9b3ef57
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/__tests__/prefer-await-to-then.js b/__tests__/prefer-await-to-then.js
@@ -21,6 +21,12 @@ ruleTester.run('prefer-await-to-then', rule, {
     }`,
     'something().then(async () => await somethingElse())',
     'function foo() { hey.somethingElse(x => {}) }',
+    `const isThenable = (obj) => {
+      return obj && typeof obj.then === 'function';
+    };`,
+    `function isThenable(obj) {
+      return obj && typeof obj.then === 'function';
+    }`,
   ],
 
   invalid: [

diff --git a/rules/prefer-await-to-then.js b/rules/prefer-await-to-then.js
@@ -35,7 +35,7 @@ module.exports = {
     }
 
     return {
-      MemberExpression(node) {
+      'CallExpression > MemberExpression.callee'(node) {
         if (isTopLevelScoped() || isInsideYieldOrAwait()) {
           return
         }