Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: Enable global strict eslint rule #191

Merged
merged 3 commits into from
Feb 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ module.exports = [
eslintPluginConfig,
prettierConfig,
{
rules: { "eslint-plugin/require-meta-docs-description": "error" },
rules: {
strict: ["error", "global"],
"eslint-plugin/require-meta-docs-description": "error",
},
},
{
// these messageIds were used outside
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/assert.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/async_hooks.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/buffer.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/cluster.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/console.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/crypto.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/dgram.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/dns.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/domain.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/events.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/fs.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/http.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/http2.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/https.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/inspector.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/module.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/net.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/os.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/path.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/perf_hooks.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/process.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/punycode.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/querystring.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/readline.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/stream.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

// TODO: https://nodejs.org/docs/latest/api/webstreams.html
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/test.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/timers.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/tls.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/tty.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/url.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/util.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/v8.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/vm.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/wasi.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins-modules/zlib.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

const { READ } = require("@eslint-community/eslint-utils")

/** @type {import('../types.js').SupportVersionTree} */
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/node-builtins.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

/** @type {import('./types.js').SupportVersionTree} */
const NodeBuiltinModules = {
...require("./node-builtins-modules/assert.js"),
Expand Down
2 changes: 2 additions & 0 deletions lib/unsupported-features/types.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict"

/**
* @typedef {Object} SupportInfo
* @property {string[]} experimental The node versions in which experimental support was added
Expand Down