-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Create a shared settings document #115
Conversation
I am not sure how to avoid this:
It seems to be the child options for |
- `exclude`: TODO | ||
- `include`: TODO | ||
- `replace`: TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmish it causes eslint-docs-generator
to report an error, when moving the options docs to another page(shared-settings). Is there a way to ignore the error?
I'm glad to help making a PR in eslint-docs-generagor
if you want. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it looks like the rule options are all mentioned in a shared doc instead, it should be safe for you to use the option --rule-doc-section-options false
to disable the check (https://github.com/bmish/eslint-doc-generator#configuration-options).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is that we mention the root option, and reference it, eg in no-extraneous-import
:
We reference convertPath
docs/rules/no-extraneous-import.md#convertpath and point to the shared setting docs/shared-settings.md#convertpath
The schema is defined here: lib/rules/no-extraneous-import.js#L27-L31
The issue is that the missing options are child properties of convertPath
:
convertPath.include
convertPath.exclude
convertPath.replace
`no-extraneous-import` rule doc should have included rule option: include
`no-extraneous-import` rule doc should have included rule option: exclude
`no-extraneous-import` rule doc should have included rule option: replace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing eslint-doc-generator option --rule-doc-section-options
is all-or-nothing in terms of checking for the options section and any named options it can detect. So with your planned design, you may just have to disable the option. Let me know if you have ideas for more granular options to control these checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonderful job! The option looks useful! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can turn off this option for now and use that option when it was supported in eslint-doc-generator
.
wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmm, I don't love the option, as you'd need to be more vigilant in PRs.
If that is fine with you, then we can proceed with the option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love it, but its disabled here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scagood --rule-doc-section-options-depth
(as it customizes the existing --rule-doc-section-options
option behavior) sounds like an interesting idea. Would you like to open an issue in eslint-doc-generator to suggest it so we can track this? I'm open to considering it if you feel that it's necessary and ideally that it would be useful to more than just this plugin.
In the meantime, you should proceed without this and just disable --rule-doc-section-options
for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to avoid breaking changes:
--rule-doc-section-options=true
can be treated asdepth: Infinity
--rule-doc-section-options=false
asdepth: 0
This is the final part of #108. Previous parts: #114, #112.
Hopefully this is a better way to document shared options in this package 👀