Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to rename n to node2 #5

Closed
giltayar opened this issue Jan 22, 2022 · 12 comments
Closed

Possibility to rename n to node2 #5

giltayar opened this issue Jan 22, 2022 · 12 comments

Comments

@giltayar
Copy link

Sorry for the bikeshedding, but "n" sounds a bit minimal. Especially in the ESlint configuration rules.

I believe any name would be suboptimal, but having the weird node in the name would, I believe be beneficial.

Something like node2 or node-new?

@voxpelli
Copy link
Member

I would prefer sticking to the current name rather than causing more fragmentation.

Changing names of a module is hard to do without breaking all of the update flows of dependent projects.

@aladdin-add
Copy link

I agreed the current name is not ideal(I tried eslint-plugin-nd while it has been taken >︿<). As of now, I'm standing with @voxpelli - It's not always an easy thing to renaming a package, for users and maintainers.

@giltayar
Copy link
Author

Good to hear that people are already using this package! Once I get the esm resolution in, I'll probably also migrate our company to use this fork.

Thanks for the hard work, and closing for lack of public interest. ☺️

@gpoole
Copy link

gpoole commented May 4, 2022

Just to throw in my 2c as a random user: I was about to open a PR on the eslint-config-standard readme because I thought the sample command to install peer dependencies had a typo in it. The name looking like a truncated version of an existing well-known package name is bound to be confusing people.

While it is a pain to rename it's only going to get harder as time goes on. Leaving the old package name published with a deprecation notice and publishing under a new name shouldn't be too bad should it? No different to publishing a major release in terms of work needed by people downstream?

@aladdin-add
Copy link

aladdin-add commented May 4, 2022

but we (other contributors) don't have the access to publish the old one- if we do, I'd prefer taking over, instead of forking. 😂

@gpoole
Copy link

gpoole commented May 4, 2022

Do you mean to publish eslint-plugin-n or the original eslint-plugin-node?

@aladdin-add
Copy link

eslint-plugin-node.

@gpoole
Copy link

gpoole commented May 4, 2022

I meant that the discussion here seemed to be saying that you can't rename this module from eslint-plugin-n because it will break things? I was asking is publishing a deprecation notice under eslint-plugin-n and publishing this under something less ambiguous like eslint-plugin-node2 so bad? Better yet what about a scoped name like @eslint-community/eslint-plugin-node as per #8? I think it would help a lot with comprehension over the current name.

Again I came here specifically for the same reason as @giltayar mentioned in the original issue: I was confused by the name because it looked like a mistake to me and wanted to suggest changing it to avoid confusion.

@aladdin-add
Copy link

I'm 👍 to @eslint-community/eslint-plugin-node. just waiting for the @eslint-community get ready.

@giltayar
Copy link
Author

+1 for anything but eslint-plugin-n. 😃

@voxpelli
Copy link
Member

The current name works until @eslint-community/eslint-plugin-node or merging into upstream becomes a possibility.

@voxpelli
Copy link
Member

As I commented in #8, there is now an ESLint RFC up regarding creating the @eslint-community: eslint/rfcs#91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants