Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: False positive for canParse in n/no-unsupported-features/node-builtins #243

Closed
1 task done
rasmuslp opened this issue Apr 14, 2024 · 0 comments · Fixed by #244 or #239 · May be fixed by YoutacRandS-VA/datatracker#4 or junsulee/Anki-Android#1
Closed
1 task done

Bug: False positive for canParse in n/no-unsupported-features/node-builtins #243

rasmuslp opened this issue Apr 14, 2024 · 0 comments · Fixed by #244 or #239 · May be fixed by YoutacRandS-VA/datatracker#4 or junsulee/Anki-Android#1
Labels
accepted bug

Comments

@rasmuslp
Copy link

Environment

Node version: 20.11.0
npm version: 10.2.4
ESLint version: 8.57.0
eslint-plugin-n version: 17.2.0
Operating System: macOS Sonoma 14.4.1

What rule do you want to report?

n/no-unsupported-features/node-builtins

Link to Minimal Reproducible Example

https://eslint-online-playground.netlify.app/#eNp1kcFOAyEQhl9lw0mTdtd4XFNPHk00Rr1ID5Sdtugy4ACmTdN3dwBrWk3DBWb++eYfZicC6Q42yvoR2vcgemGsdxSbRGOzJGcbKdAN0PNbihuJErXDEJs1wbKZcXYdow99161MXKdFq53tIIwG45SvNqGJ20PAj2llcIoF1EhkZvvydN9qhY+KAlxk6KWYiLYWkGZLDtnUjvXcCzYRcAhS9M0bv4qoJ8iNOA6DFBNW1TY9dieZ+aQyfO5EDz4aniOTCrvQtVWvQIETOS7FqCKEyNCDIrhEGp63HqrAuiGNfM/5/Q+fOHLK/UyOOQfTRI6qz8GlRa6el3KJe57cK/2hVnkVx3MP8HUHPg+C2vyh1184Y/jfxx+rjl0DsuCXLCOfsvdacTu7vsp6GYvN/TdBo75l

What did you expect to happen?

Rule reports that URL.canParse is still an experimental feature, and I don't believe that is correct.

According to Node documentation [1] this API was added in 19.9.0, but there is no mention of it being experimental.

[1] https://nodejs.org/docs/latest-v20.x/api/url.html#urlcanparseinput-base

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@rasmuslp rasmuslp added the bug label Apr 14, 2024
scagood added a commit that referenced this issue Apr 14, 2024
@scagood
fix(unsupported-features): Improve URL module
9fe6425 
fixes #243
@scagood scagood mentioned this issue Apr 14, 2024
Merged
@rasmuslp rasmuslp mentioned this issue Apr 14, 2024
Closed
aladdin-add pushed a commit that referenced this issue Apr 15, 2024
@scagood
fix(unsupported-features): Improve URL module (#244)
6581979 
fixes #243
@github-actions github-actions bot mentioned this issue Apr 15, 2024
Merged
@lholmquist lholmquist mentioned this issue May 21, 2024
Closed
This was referenced May 29, 2024
Closed
Closed
Closed
@YoutacRandS-VA YoutacRandS-VA mentioned this issue Jun 20, 2024
Open
@junsulee junsulee mentioned this issue Jun 25, 2024
Open
This was referenced Jun 27, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(unsupported-features): Improve URL module eslint-community/eslint-plugin-n
chore(master): release 17.2.1 eslint-community/eslint-plugin-n
[Snyk] Upgrade eslint-plugin-n from 16.6.2 to 17.7.0 YoutacRandS-VA/datatracker
[Snyk] Upgrade eslint-plugin-n from 16.6.2 to 17.7.0 junsulee/Anki-Android
fix(no-unsupported-features/node-builtins): URL.canParse is stable rasmuslp/eslint-plugin-n
[Snyk] Upgrade eslint-plugin-n from 16.0.2 to 17.4.0 nodeshift/kube-service-bindings
[Snyk] Upgrade eslint-plugin-n from 16.0.2 to 17.5.1 nodeshift/kube-service-bindings
[Snyk] Upgrade eslint-plugin-n from 16.0.2 to 17.6.0 nodeshift/kube-service-bindings
[Snyk] Upgrade eslint-plugin-n from 16.0.2 to 17.7.0 nodeshift/kube-service-bindings
[Snyk] Upgrade eslint-plugin-n from 16.0.2 to 17.8.0 nodeshift/kube-service-bindings
2 participants
@rasmuslp @scagood